Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate the toast #2283

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Consolidate the toast #2283

merged 2 commits into from
Jun 16, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 16, 2023

Some toast popped up from the bottom. Other toast appeared in the designated location (upper-right corner), but twice. This rectifies both.


This change is Reviewable

@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. labels Jun 16, 2023
@imnasnainaec imnasnainaec self-assigned this Jun 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a85b6be) 74.49% compared to head (590eaa0) 74.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2283   +/-   ##
=======================================
  Coverage   74.49%   74.49%           
=======================================
  Files          44       44           
  Lines        4121     4121           
=======================================
  Hits         3070     3070           
  Misses       1051     1051           
Flag Coverage Δ
backend 74.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) June 16, 2023 20:26
@imnasnainaec imnasnainaec merged commit 7f8b3b0 into master Jun 16, 2023
@imnasnainaec imnasnainaec deleted the toast-in-corner branch June 16, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants