Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for circular dependencies #2305

Merged
merged 5 commits into from
Jun 26, 2023
Merged

Check for circular dependencies #2305

merged 5 commits into from
Jun 26, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 19, 2023

This change is Reviewable

@imnasnainaec imnasnainaec added the maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. label Jun 19, 2023
@imnasnainaec imnasnainaec self-assigned this Jun 19, 2023
@imnasnainaec imnasnainaec enabled auto-merge (squash) June 23, 2023 21:10
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ab65722) 74.49% compared to head (026d2e5) 74.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2305   +/-   ##
=======================================
  Coverage   74.49%   74.49%           
=======================================
  Files          44       44           
  Lines        4121     4121           
=======================================
  Hits         3070     3070           
  Misses       1051     1051           
Flag Coverage Δ
backend 74.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 59f4994 into master Jun 26, 2023
@imnasnainaec imnasnainaec deleted the madge-deps branch June 26, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants