Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Resolve CA1711, CA1725, CA2215, CA2229 #2328

Merged
merged 5 commits into from
Jun 28, 2023
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 27, 2023

Parts of #2111


This change is Reviewable

@imnasnainaec imnasnainaec added backend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. labels Jun 27, 2023
@imnasnainaec imnasnainaec self-assigned this Jun 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Patch coverage: 27.27% and project coverage change: +14.43 🎉

Comparison is base (494da2a) 46.45% compared to head (2f572ed) 60.89%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2328       +/-   ##
===========================================
+ Coverage   46.45%   60.89%   +14.43%     
===========================================
  Files         198      243       +45     
  Lines        3954     8236     +4282     
  Branches      514      514               
===========================================
+ Hits         1837     5015     +3178     
- Misses       1740     2844     +1104     
  Partials      377      377               
Flag Coverage Δ
backend 74.21% <27.27%> (?)
frontend 46.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Backend/Helper/FileOperations.cs 81.96% <0.00%> (ø)
Backend/Helper/LiftHelper.cs 86.66% <0.00%> (ø)
Backend/Models/UserRole.cs 100.00% <ø> (ø)
Backend/Services/LiftService.cs 93.85% <0.00%> (ø)
Backend/Services/MergeService.cs 76.51% <0.00%> (ø)
Backend/Services/PermissionService.cs 0.00% <0.00%> (ø)
Backend/Helper/FileStorage.cs 96.55% <25.00%> (ø)
Backend/Services/UserEditService.cs 75.00% <100.00%> (ø)

... and 37 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@imnasnainaec imnasnainaec changed the title [Backend] Fix CA1725 and CA2229 [Backend] Address CA1725, CA2215, CA2229 Jun 28, 2023
@imnasnainaec imnasnainaec changed the title [Backend] Address CA1725, CA2215, CA2229 [Backend] Resolve CA1711, CA1725, CA2215, CA2229 Jun 28, 2023
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 6 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit e420fce into master Jun 28, 2023
@imnasnainaec imnasnainaec deleted the backend-analysis branch June 28, 2023 20:44
imnasnainaec added a commit that referenced this pull request Sep 5, 2023
imnasnainaec added a commit that referenced this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants