Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort writing systems retrieved from import LDMLs #2349

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 4, 2023

Resolves #2340


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jul 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Patch coverage: 97.77% and project coverage change: +14.15 🎉

Comparison is base (c3fd42f) 46.97% compared to head (1928b6c) 61.13%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2349       +/-   ##
===========================================
+ Coverage   46.97%   61.13%   +14.15%     
===========================================
  Files         195      240       +45     
  Lines        4002     8303     +4301     
  Branches      521      521               
===========================================
+ Hits         1880     5076     +3196     
- Misses       1742     2847     +1105     
  Partials      380      380               
Flag Coverage Δ
backend 74.30% <97.77%> (?)
frontend 46.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Backend/Controllers/LiftController.cs 54.18% <75.00%> (ø)
Backend/Helper/GrammaticalCategory.cs 100.00% <100.00%> (ø)
Backend/Helper/Language.cs 87.75% <100.00%> (ø)
Backend/Helper/LiftHelper.cs 86.66% <100.00%> (ø)
Backend/Models/Project.cs 98.68% <100.00%> (ø)
Backend/Services/LiftService.cs 93.71% <100.00%> (ø)

... and 39 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)


Backend/Helper/Language.cs line 60 at r1 (raw file):

        public static int CompareWritingSystems(WritingSystem x, WritingSystem y)
        {
            var xTag = x.Bcp47;

So your language tag processing here is minimal, and looks correct and safe , but you should be aware of the IetfLanguageTag class in SIL.WritingSystems. It might be overkill here, but it could be useful. https://github.com/sillsdev/libpalaso/blob/master/SIL.WritingSystems/IetfLanguageTag.cs

@imnasnainaec imnasnainaec merged commit efb46fa into master Jul 5, 2023
@imnasnainaec imnasnainaec deleted the import-lang-sort branch July 5, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CreateProject] When importing a file, sort vernacular language options
3 participants