Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SiteSettings] Enable add user to project #2372

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 13, 2023

Resolves #708

Acceptance test:

  • Login with a user that is a site admin
  • Click on user avatar on the right end of the top bar
  • Select "Site Settings"
  • Under "Projects", next to any project, click the "Project Roles" button
  • Under "Add project users", add a user to the project

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -10.64 ⚠️

Comparison is base (bc88e66) 73.65% compared to head (45749fc) 63.01%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2372       +/-   ##
===========================================
- Coverage   73.65%   63.01%   -10.64%     
===========================================
  Files          45      240      +195     
  Lines        4410     8225     +3815     
  Branches        0      505      +505     
===========================================
+ Hits         3248     5183     +1935     
- Misses       1162     2682     +1520     
- Partials        0      360      +360     
Flag Coverage Δ
backend 73.65% <ø> (ø)
frontend 50.72% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/ProjectSettings/ProjectUsers/AddProjectUsers.tsx 5.55% <0.00%> (ø)
src/components/ProjectSettings/index.tsx 69.56% <ø> (ø)
...tManagement/ProjectUsersButtonWithConfirmation.tsx 27.27% <0.00%> (ø)
...mponents/ProjectSettings/ProjectUsers/UserList.tsx 79.54% <100.00%> (ø)

... and 191 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@imnasnainaec imnasnainaec enabled auto-merge (squash) July 19, 2023 16:07
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 3 of 7 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)


src/components/ProjectSettings/ProjectUsers/AddProjectUsers.tsx line 66 at r2 (raw file):

        <UserList
          addToProject={addToProject}
          minSearchLength={props.siteAdmin ? 1 : 3}

So siteAdmin starts filtering at 1 character?

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 7 files reviewed, all discussions resolved (waiting on @imnasnainaec and @jasonleenaylor)


src/components/ProjectSettings/ProjectUsers/AddProjectUsers.tsx line 66 at r2 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

So siteAdmin starts filtering at 1 character?

Yes, consistent with what we have in Site Settings user management.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 7 files at r1.
Reviewable status: 6 of 7 files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 7 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 2f66be5 into master Jul 20, 2023
14 checks passed
@imnasnainaec imnasnainaec deleted the site-settings-proj-add-user branch July 20, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SiteSettings] Allow site admins to change user roles on a project
3 participants