-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SiteSettings] Enable add user to project #2372
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2372 +/- ##
===========================================
- Coverage 73.65% 63.01% -10.64%
===========================================
Files 45 240 +195
Lines 4410 8225 +3815
Branches 0 505 +505
===========================================
+ Hits 3248 5183 +1935
- Misses 1162 2682 +1520
- Partials 0 360 +360
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 3 of 7 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
src/components/ProjectSettings/ProjectUsers/AddProjectUsers.tsx
line 66 at r2 (raw file):
<UserList addToProject={addToProject} minSearchLength={props.siteAdmin ? 1 : 3}
So siteAdmin starts filtering at 1 character?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 7 files reviewed, all discussions resolved (waiting on @imnasnainaec and @jasonleenaylor)
src/components/ProjectSettings/ProjectUsers/AddProjectUsers.tsx
line 66 at r2 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
So siteAdmin starts filtering at 1 character?
Yes, consistent with what we have in Site Settings user management.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 7 files at r1.
Reviewable status: 6 of 7 files reviewed, all discussions resolved (waiting on @imnasnainaec)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 7 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Resolves #708
Acceptance test:
This change is