[DuplicateFinder] Add penalty if no common gram cat group #2445
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2445 +/- ##
==========================================
+ Coverage 67.91% 67.96% +0.04%
==========================================
Files 240 240
Lines 8254 8270 +16
Branches 508 508
==========================================
+ Hits 5606 5621 +15
- Misses 2289 2290 +1
Partials 359 359
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
Backend/Helper/DuplicateFinder.cs line 298 at r2 (raw file):
/// or if the grammatical category group is unspecified in every sense of one of the words. /// </summary> public static bool MightShareGramCatGroups(Word wordA, Word wordB)
Not sure that I like Might. Sounds too wishy washy. I'd rather negate it and go with HasDifferentGramCat, or something similar.
Code quote:
MightShare
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @jasonleenaylor)
Backend/Helper/DuplicateFinder.cs line 298 at r2 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
Not sure that I like Might. Sounds too wishy washy. I'd rather negate it and go with HasDifferentGramCat, or something similar.
I've changed it toHaveCommonGramCatGroup; does that work better? I was also considering negating HasDifferentGramCatGroups.
If WordA has a Noun sense and WordB has an Unspecified sense, is it better to say they have a common grammatical category group or that they don't have different grammatical category groups?
If WordA has a Noun sense and WordC has one Verb sense and one Unspecified sense, is it better to say they don't have a common grammatical category group or that they do have different grammatical category groups?
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
Backend/Helper/DuplicateFinder.cs line 298 at r2 (raw file):
Previously, imnasnainaec (D. Ror.) wrote…
I've changed it to
HaveCommonGramCatGroup; does that work better? I was also considering negatingHasDifferentGramCatGroups.If
WordAhas aNounsense andWordBhas anUnspecifiedsense, is it better to say they have a common grammatical category group or that they don't have different grammatical category groups?If
WordAhas aNounsense andWordChas oneVerbsense and oneUnspecifiedsense, is it better to say they don't have a common grammatical category group or that they do have different grammatical category groups?
For your first example I would say it is better to say they don't have a different one.
The second example does muddy the waters.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jasonleenaylor)
Backend/Helper/DuplicateFinder.cs line 298 at r2 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
For your first example I would say it is better to say they don't have a different one.
The second example does muddy the waters.
Done.
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Closes #604
Todo: generate test data for acceptance testing
This change is