Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure VSCode to warn on commits to master, main #2450

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

jmgrady
Copy link
Collaborator

@jmgrady jmgrady commented Aug 3, 2023

This adds a warning when committing through VSCode's "Source Control" panel (not when committing via a cli opened in VSCode).

This change is Reviewable

@jmgrady jmgrady added the tools label Aug 3, 2023
@jmgrady jmgrady self-assigned this Aug 3, 2023
@jmgrady jmgrady enabled auto-merge (squash) August 3, 2023 16:06
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (37ad51d) 67.98% compared to head (71aab68) 67.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2450      +/-   ##
==========================================
- Coverage   67.98%   67.96%   -0.02%     
==========================================
  Files         240      240              
  Lines        8270     8270              
  Branches      508      508              
==========================================
- Hits         5622     5621       -1     
- Misses       2289     2290       +1     
  Partials      359      359              
Flag Coverage Δ
backend 79.66% <ø> (-0.03%) ⬇️
frontend 54.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec requested review from Apoktieno and removed request for imnasnainaec August 3, 2023 16:55
Copy link
Contributor

@Apoktieno Apoktieno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)

@jmgrady jmgrady merged commit 23fa976 into master Aug 3, 2023
14 checks passed
@jmgrady jmgrady deleted the vscode-config branch August 3, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants