Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AppBar for windows <400px wide #2637

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Improve AppBar for windows <400px wide #2637

merged 5 commits into from
Sep 26, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Sep 25, 2023

Resolves #2251

Looks good down to 350 px width:
Screenshot 2023-09-25 151347

Narrower than that, overflows to a second row but is still usable down to 220 px width:
Screenshot 2023-09-25 151424


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Sep 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

see 202 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) September 26, 2023 16:45
@imnasnainaec imnasnainaec merged commit e467661 into master Sep 26, 2023
16 checks passed
@imnasnainaec imnasnainaec deleted the app-bar-narrow branch September 26, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AppBar] Improve layout for narrow windows
3 participants