Remove vestigial check for baseUrl property

[imnasnainaec]

This change is 

[codecov-commenter]

Codecov Report

All modified lines are covered by tests ✅

see 202 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

[jmgrady]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)

---

src/types/runtimeConfig.ts line 51 at r1 (raw file):

    return defaultConfig.baseUrl;
  }

Should also to remove the reference in nginx/init/25-combine-runtime-config.sh:

env_map=(
  ["CONFIG_BASE_URL"]="baseUrl"
  ["CONFIG_USE_CONNECTION_URL"]="useConnectionBaseUrlForApi"
  ["CONFIG_CAPTCHA_REQD"]="captchaRequired"
  ["CONFIG_CAPTCHA_SITE_KEY"]="captchaSiteKey"
  ["CONFIG_ANALYTICS_WRITE_KEY"]="analyticsWriteKey"
  ["CONFIG_OFFLINE"]="offline"
  ["CONFIG_EMAIL_ENABLED"]="emailServicesEnabled"
  ["CONFIG_SHOW_CERT_EXPIRATION"]="showCertExpiration"
)

(Sorry I did not think of this yesterday when we discussed this change.)

[imnasnainaec]

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec and @jmgrady)

---

src/types/runtimeConfig.ts line 51 at r1 (raw file):

Previously, jmgrady (Jim Grady) wrote…

Should also to remove the reference in nginx/init/25-combine-runtime-config.sh:

env_map=(
  ["CONFIG_BASE_URL"]="baseUrl"
  ["CONFIG_USE_CONNECTION_URL"]="useConnectionBaseUrlForApi"
  ["CONFIG_CAPTCHA_REQD"]="captchaRequired"
  ["CONFIG_CAPTCHA_SITE_KEY"]="captchaSiteKey"
  ["CONFIG_ANALYTICS_WRITE_KEY"]="analyticsWriteKey"
  ["CONFIG_OFFLINE"]="offline"
  ["CONFIG_EMAIL_ENABLED"]="emailServicesEnabled"
  ["CONFIG_SHOW_CERT_EXPIRATION"]="showCertExpiration"
)

(Sorry I did not think of this yesterday when we discussed this change.)

Done.

[jmgrady]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)