Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken statistics by adding timestamp on new entries #2659

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 2, 2023

Resolves #2658 and makes words-per-day-per-user more robust.


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Oct 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/components/DataEntry/DataEntryTable/index.tsx 62.53% <100.00%> (ø)
Backend/Services/StatisticsService.cs 60.32% <0.00%> (-0.25%) ⬇️

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to fast track, but the DataEntry change seem like it should be unit testable in a follow up commit if necessary.
:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit bb8d5b6 into master Oct 2, 2023
16 checks passed
@imnasnainaec imnasnainaec deleted the stats-sd-created branch October 2, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First semantic domain of a word missing created timestamp
3 participants