Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 4 unused functions from backend/index.ts #2660

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Remove 4 unused functions from backend/index.ts #2660

merged 2 commits into from
Oct 9, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 2, 2023 •
edited
Loading

Removed:

  • SemanticDomainController > getAllSemanticDomainTreeNodes
  • StatisticsController > getWordsPerDayPerUserCounts
  • UserEditController > getAllUserEdits
  • WordController > getAllWords

This change is Reviewable

@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. labels Oct 2, 2023
@imnasnainaec imnasnainaec self-assigned this Oct 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

see 205 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

jasonleenaylor
jasonleenaylor approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) October 9, 2023 14:18
@imnasnainaec imnasnainaec merged commit 25be862 into master Oct 9, 2023
16 checks passed
@imnasnainaec imnasnainaec deleted the backend-unused branch October 9, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonleenaylor jasonleenaylor jasonleenaylor approved these changes

Assignees

@imnasnainaec imnasnainaec

Labels
frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imnasnainaec @codecov-commenter @jasonleenaylor