Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InviteController] Clean up logic and add tests #2663

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 2, 2023

Progress on #2647


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
Backend/Controllers/InviteController.cs 91.86% <93.75%> (+91.86%) ⬆️

... and 206 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@imnasnainaec imnasnainaec marked this pull request as ready for review October 3, 2023 15:00
@imnasnainaec imnasnainaec changed the title Create InviteControllerTests.cs [InviteController] Clean up logic and add tests Oct 3, 2023
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec and @jmgrady)


Backend/Controllers/InviteController.cs line 150 at r2 (raw file):

        public bool IsTokenValid { get; set; }
        [Required]
        public bool isUserValid { get; set; }

Is (C# style for properties)

Code quote:

is

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @jasonleenaylor and @jmgrady)


Backend/Controllers/InviteController.cs line 150 at r2 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

Is (C# style for properties)

Done.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)

@imnasnainaec imnasnainaec enabled auto-merge (squash) October 10, 2023 15:22
@imnasnainaec imnasnainaec merged commit 47537c4 into master Oct 10, 2023
16 of 17 checks passed
@imnasnainaec imnasnainaec deleted the backend-tests branch October 10, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants