Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust DomainTileButton dimensions #2683

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Adjust DomainTileButton dimensions #2683

merged 3 commits into from
Oct 10, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 5, 2023

Improves #2682 by allowing the tree to fit in width 850px (more useable, e.g., on a tablet), but may make #1617 a little worse.


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Oct 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...onents/TreeView/TreeDepiction/DomainTileButton.tsx 90.90% <ø> (ø)

... and 45 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) October 10, 2023 20:13
@imnasnainaec imnasnainaec merged commit 7037c5c into master Oct 10, 2023
17 checks passed
@imnasnainaec imnasnainaec deleted the tree-width branch October 10, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants