Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ExistingDataTable] Show all glosses, with primary analysis lang first #2688

Merged
merged 10 commits into from
Oct 20, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 6, 2023

Fixes #2686


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Oct 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@imnasnainaec imnasnainaec marked this pull request as ready for review October 10, 2023 19:59
@jasonleenaylor
Copy link
Contributor

src/components/DataEntry/ExistingDataTable/ImmutableExistingData.tsx line 23 at r2 (raw file):

        item
        xs={5}
        key={"vernacular_" + props.vernacular}

So it's happy (no warnings) without a key here now?

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 8 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) October 20, 2023 12:52
@imnasnainaec imnasnainaec merged commit d7d73e5 into master Oct 20, 2023
16 checks passed
@imnasnainaec imnasnainaec deleted the data-entry-existing-glosses branch October 20, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataEntry] Side list of existing entries in a domain only shows first gloss
3 participants