Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Actions] Split the longest-to-run workflow job into two #2734

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 23, 2023

This change is Reviewable

@imnasnainaec imnasnainaec added the maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. label Oct 23, 2023
@imnasnainaec imnasnainaec self-assigned this Oct 23, 2023
@imnasnainaec imnasnainaec changed the title [Github Actions] Split the longest-to-run workflow job into two [GitHub Actions] Split the longest-to-run workflow job into two Oct 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)


.github/workflows/frontend.yml line 40 at r1 (raw file):

      - run: npm run fmt-frontend-check
      - run: npm run lint
      - run: npm run build

Is this still required? We verify that the frontend builds correctly in the docker_build job.

Code quote:

      - run: npm run build

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit a35a143 into master Oct 26, 2023
17 checks passed
@imnasnainaec imnasnainaec deleted the github-action-frontend branch October 26, 2023 15:33
@imnasnainaec imnasnainaec added the github_actions Pull requests that update GitHub Actions code label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants