Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TreeSearch] If trailing period after backspace, remove it #2745

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 26, 2023

Resolves #1492


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Oct 26, 2023
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) November 6, 2023 22:50
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Files Coverage Δ
Backend/Services/LiftService.cs 94.09% <ø> (+2.36%) ⬆️
src/components/DataEntry/index.tsx 81.57% <0.00%> (ø)
src/components/TreeView/TreeSearch.tsx 90.90% <80.00%> (-6.53%) ⬇️

... and 4 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@imnasnainaec imnasnainaec merged commit 74801d2 into master Nov 6, 2023
17 checks passed
@imnasnainaec imnasnainaec deleted the tree-search-backspace-period branch November 6, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backspace in domain search delete number and period
3 participants