Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataEntryTable] Prevent RecentEntry re-rendering when typing in NewEntry #2752

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 31, 2023

Improves #2750


This change is Reviewable

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

see 204 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@imnasnainaec imnasnainaec changed the title [DataEntryTable] Prevent RecentEntry from re-rendering unnecessarily [DataEntryTable] Prevent RecentEntry from re-rendering when typing in NewEntry Oct 31, 2023
@imnasnainaec imnasnainaec changed the title [DataEntryTable] Prevent RecentEntry from re-rendering when typing in NewEntry [DataEntryTable] Prevent RecentEntry re-rendering when typing in NewEntry Oct 31, 2023
Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) November 2, 2023 21:03
@imnasnainaec imnasnainaec merged commit b9252e2 into master Nov 2, 2023
17 checks passed
@imnasnainaec imnasnainaec deleted the data-entry-slow branch November 2, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants