Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Project to use redux-toolkit #2754

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 31, 2023

Part of #1953


This change is Reviewable

@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. project labels Oct 31, 2023
@imnasnainaec imnasnainaec self-assigned this Oct 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/components/Project/ProjectReducer.ts 100.00% <100.00%> (+25.00%) ⬆️
src/rootReducer.ts 100.00% <ø> (ø)
src/components/Project/ProjectActions.ts 90.47% <84.61%> (+80.47%) ⬆️

... and 44 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@imnasnainaec imnasnainaec marked this pull request as ready for review November 1, 2023 17:55
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 7 files at r1, 2 of 3 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)

@imnasnainaec imnasnainaec merged commit c7aaa71 into master Nov 13, 2023
17 checks passed
@imnasnainaec imnasnainaec deleted the redux-toolkit-project branch November 13, 2023 13:57
@imnasnainaec imnasnainaec removed the request for review from jmgrady November 13, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants