-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Login, Signup to function components #2777
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2777 +/- ##
===========================================
+ Coverage 71.42% 82.85% +11.43%
===========================================
Files 247 44 -203
Lines 9369 4533 -4836
Branches 1075 530 -545
===========================================
- Hits 6692 3756 -2936
+ Misses 2360 643 -1717
+ Partials 317 134 -183
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 11 files at r1, 13 of 13 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
src/components/Login/Signup.tsx
line 46 at r2 (raw file):
const defaultSignupError: SignupError = { [SignupField.Email]: false,
Oooh, fancy.
This change is