Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Login, Signup to function components #2777

Merged
merged 10 commits into from
Nov 14, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Nov 2, 2023

This change is Reviewable

@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. login/signUp labels Nov 2, 2023
@imnasnainaec imnasnainaec self-assigned this Nov 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (51f9db2) 71.42% compared to head (a69a7b1) 82.85%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2777       +/-   ##
===========================================
+ Coverage   71.42%   82.85%   +11.43%     
===========================================
  Files         247       44      -203     
  Lines        9369     4533     -4836     
  Branches     1075      530      -545     
===========================================
- Hits         6692     3756     -2936     
+ Misses       2360      643     -1717     
+ Partials      317      134      -183     
Flag Coverage Δ
backend 82.85% <ø> (+0.02%) ⬆️
frontend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as ready for review November 3, 2023 13:29
@imnasnainaec imnasnainaec changed the title Convert Login to function component Convert Login, Signup to function components Nov 3, 2023
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 11 files at r1, 13 of 13 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)


src/components/Login/Signup.tsx line 46 at r2 (raw file):

const defaultSignupError: SignupError = {
  [SignupField.Email]: false,

Oooh, fancy.

@imnasnainaec imnasnainaec enabled auto-merge (squash) November 14, 2023 23:19
@imnasnainaec imnasnainaec merged commit 8947af6 into master Nov 14, 2023
17 checks passed
@imnasnainaec imnasnainaec deleted the login-function-component branch November 14, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend login/signUp maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants