-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't retrieve 0-sense words from the database #2789
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @imnasnainaec)
Backend/Repositories/WordRepository.cs
line 210 at r1 (raw file):
/// <summary> Updates <see cref="Word"/> in the Frontier collection with same wordId and projectId </summary> /// <returns> A bool: success of operation </returns> public async Task<bool> UpdateFrontier(Word word)
Was this obsolete?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @jasonleenaylor)
Backend/Repositories/WordRepository.cs
line 210 at r1 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
Was this obsolete?
Unused and not in IWordRepository
, so unusable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Resolves #1700
This change is