Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't retrieve 0-sense words from the database #2789

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Nov 13, 2023

Resolves #1700


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working backend labels Nov 13, 2023
@imnasnainaec imnasnainaec self-assigned this Nov 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @imnasnainaec)


Backend/Repositories/WordRepository.cs line 210 at r1 (raw file):

        /// <summary> Updates <see cref="Word"/> in the Frontier collection with same wordId and projectId </summary>
        /// <returns> A bool: success of operation </returns>
        public async Task<bool> UpdateFrontier(Word word)

Was this obsolete?

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @jasonleenaylor)


Backend/Repositories/WordRepository.cs line 210 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

Was this obsolete?

Unused and not in IWordRepository, so unusable.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 179d3c8 into master Nov 13, 2023
17 checks passed
@imnasnainaec imnasnainaec deleted the senseless-words branch November 13, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

At a certian point, Merge Duplicates shows a blank screen after the animation.
3 participants