Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MergeDragDrop] Add basic tests #2792

Merged
merged 7 commits into from
Nov 15, 2023
Merged

[MergeDragDrop] Add basic tests #2792

merged 7 commits into from
Nov 15, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Nov 15, 2023

Resolves #2646


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (c3bd185) 71.78% compared to head (04c0768) 72.79%.

Files Patch % Lines
...geDuplicates/MergeDupsStep/MergeDragDrop/index.tsx 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2792      +/-   ##
==========================================
+ Coverage   71.78%   72.79%   +1.01%     
==========================================
  Files         246      246              
  Lines        9348     9349       +1     
  Branches     1077     1077              
==========================================
+ Hits         6710     6806      +96     
+ Misses       2319     2219     -100     
- Partials      319      324       +5     
Flag Coverage Δ
backend 82.94% <ø> (+0.11%) ⬆️
frontend 63.24% <48.00%> (+1.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 642eae3 into master Nov 15, 2023
17 checks passed
@imnasnainaec imnasnainaec deleted the merge-dups-step-test branch November 15, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No unit test coverage for MergeDupsStep
3 participants