Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize DataEntryTableState #2794

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Organize DataEntryTableState #2794

merged 4 commits into from
Dec 4, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Nov 16, 2023

Also:

  • Correct /*** comments */ to /** comments */
  • Remove setThings (of const [things, setThings] = useState()) from useEffect dependency lists
  • Replace <Fragment>{stuff}</Fragment> with <>{stuff}</>

This change is Reviewable

@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. component: DataEntry labels Nov 16, 2023
@imnasnainaec imnasnainaec self-assigned this Nov 16, 2023
@imnasnainaec imnasnainaec marked this pull request as draft November 16, 2023 14:43
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9294a04) 72.38% compared to head (666c8ff) 72.37%.

Files Patch % Lines
src/components/DataEntry/DataEntryTable/index.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2794      +/-   ##
==========================================
- Coverage   72.38%   72.37%   -0.01%     
==========================================
  Files         253      253              
  Lines        9469     9471       +2     
  Branches     1093     1093              
==========================================
+ Hits         6854     6855       +1     
  Misses       2288     2288              
- Partials      327      328       +1     
Flag Coverage Δ
backend 82.87% <ø> (-0.03%) ⬇️
frontend 62.70% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as ready for review November 16, 2023 15:22
@imnasnainaec imnasnainaec changed the title Organize ReviewEntriesTableState Organize DataEntryTableState Nov 17, 2023
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 20 files at r1, 9 of 9 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 20 files at r1, 8 of 9 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 79100ad into master Dec 4, 2023
17 checks passed
@imnasnainaec imnasnainaec deleted the data-entry-table-state branch December 4, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: DataEntry frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants