Use Helm chart hooks for Jobs to initialize cluster resources #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmgrady
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2828 +/- ##
==========================================
+ Coverage 72.38% 72.43% +0.04%
==========================================
Files 257 257
Lines 9507 9507
Branches 1096 1096
==========================================
+ Hits 6882 6886 +4
+ Misses 2299 2296 -3
+ Partials 326 325 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
imnasnainaec
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jmgrady)
jmgrady
added a commit
that referenced
this pull request
Mar 6, 2024
* Rename cron job that updates the fonts * Fix pull policy for create-admin-user * Make ECR login job and update cert job chart hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the one-shot jobs so that they are run on a new install or an update of The Combine.
Also changed the name of
cronjob-weekly-get-fonts.yamltocronjob-update-fonts.yamlsince the period is an attribute of the resource and need not be weekly.This change is