Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Guide] Add Spanish and Chinese screenshots #2832

Merged
merged 7 commits into from
Dec 14, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Dec 11, 2023

Resolves #2728


This change is Reviewable

@imnasnainaec imnasnainaec added documentation Improvements or additions to documentation font/language labels Dec 11, 2023
@imnasnainaec imnasnainaec self-assigned this Dec 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d69f7d1) 72.33% compared to head (7f768df) 82.94%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2832       +/-   ##
===========================================
+ Coverage   72.33%   82.94%   +10.60%     
===========================================
  Files         257       44      -213     
  Lines        9520     4555     -4965     
  Branches     1097      534      -563     
===========================================
- Hits         6886     3778     -3108     
+ Misses       2307      644     -1663     
+ Partials      327      133      -194     
Flag Coverage Δ
backend 82.94% <ø> (-0.03%) ⬇️
frontend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec changed the title Add Spanish and Chinese versions for about half the screenshots [User Guide] Add Spanish and Chinese screenshots Dec 12, 2023
@imnasnainaec imnasnainaec marked this pull request as ready for review December 12, 2023 23:05
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotchecked RSLGTM

Reviewed 5 of 48 files at r1, 6 of 29 files at r2, all commit messages.
Reviewable status: 11 of 75 files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 46 of 48 files at r1, 29 of 29 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 862fb34 into master Dec 14, 2023
17 checks passed
@imnasnainaec imnasnainaec deleted the user-guide-localize-screenshots branch December 14, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation font/language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[User Guide] Make screen-shots for non-English pages
3 participants