Use targeted useAppSelector to avoid sidebar rerender loop #2834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonleenaylor
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1, all commit messages.
Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @imnasnainaec)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2834 +/- ##
==========================================
- Coverage 72.37% 72.37% -0.01%
==========================================
Files 257 257
Lines 9507 9520 +13
Branches 1096 1097 +1
==========================================
+ Hits 6881 6890 +9
- Misses 2300 2304 +4
Partials 326 326
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jmgrady
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Reviewed 1 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have components pull only what they need from the state to avoid sidebar dispatches from causing rerenders.
Fixes #2833
This change is