Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataEntry] Clear note dialog text #2835

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Dec 12, 2023

There are two instances in Data Entry where the text of the note dialog isn't being cleared but should be:

  • If you add a note to the New Entry then delete the New Entry, the icon of the note changes to that of an empty note, but when you click to add a new note, the old note text is there.
  • If you start adding or editing a note and cancel via ESC, then click to add/edit the note, your previous edits will be there.

This pr fixes both of those.


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Dec 12, 2023
@imnasnainaec imnasnainaec changed the title Clear note dialog text [DataEntry] Clear note dialog text Dec 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (862fb34) 72.27% compared to head (50c5865) 72.33%.

Files Patch % Lines
src/components/Dialogs/EditTextDialog.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2835      +/-   ##
==========================================
+ Coverage   72.27%   72.33%   +0.05%     
==========================================
  Files         257      257              
  Lines        9520     9522       +2     
  Branches     1097     1097              
==========================================
+ Hits         6881     6888       +7     
+ Misses       2311     2308       -3     
+ Partials      328      326       -2     
Flag Coverage Δ
backend 82.96% <ø> (+0.10%) ⬆️
frontend 62.59% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 45e7619 into master Dec 14, 2023
17 checks passed
@imnasnainaec imnasnainaec deleted the new-entry-note-delete branch December 14, 2023 18:55
jmgrady pushed a commit that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants