Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TreeView] Have down arrow go to first child #2840

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Dec 15, 2023

Up arrow goes to parent, side arrows go to siblings, down arrow only works when there's only one child.

While writing a script for the domain tree tutorial, I felt it was more natural to use (and explain) if the down arrow goes to the first child if there are multiple children (sub)domains.


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45e7619) 72.32% compared to head (b13872c) 72.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2840   +/-   ##
=======================================
  Coverage   72.32%   72.33%           
=======================================
  Files         257      257           
  Lines        9522     9521    -1     
  Branches     1097     1097           
=======================================
  Hits         6887     6887           
+ Misses       2308     2307    -1     
  Partials      327      327           
Flag Coverage Δ
backend 82.96% <ø> (+0.02%) ⬆️
frontend 62.58% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit a90c73e into master Dec 15, 2023
17 checks passed
@imnasnainaec imnasnainaec deleted the down-arrow branch December 15, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants