Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataEntry] Give longer gloss spelling suggestions #2842

Merged
merged 14 commits into from
Jan 9, 2024
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Dec 18, 2023

Resolves #487


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3dfd736) 83.17% compared to head (e0d568c) 83.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2842   +/-   ##
=======================================
  Coverage   83.17%   83.17%           
=======================================
  Files          46       46           
  Lines        4808     4808           
  Branches      568      568           
=======================================
  Hits         3999     3999           
  Misses        671      671           
  Partials      138      138           
Flag Coverage Δ
backend 83.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as ready for review January 4, 2024 16:26
@imnasnainaec imnasnainaec marked this pull request as draft January 4, 2024 16:31
@imnasnainaec imnasnainaec marked this pull request as ready for review January 4, 2024 18:40
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) January 9, 2024 18:26
@imnasnainaec imnasnainaec merged commit 32c22c7 into master Jan 9, 2024
17 checks passed
@imnasnainaec imnasnainaec deleted the typeahead branch January 9, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gloss auto suggestions are lacking
3 participants