Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataEntry] Auto merge new entry with empty selected dup sense #2866

Merged
merged 15 commits into from
Jan 16, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 2, 2024

Resolves #1722


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (a8e6f4f) 72.61% compared to head (a503e63) 72.89%.

Files Patch % Lines
src/components/DataEntry/DataEntryTable/index.tsx 59.18% 10 Missing and 10 partials ⚠️
...onents/DataEntry/DataEntryTable/NewEntry/index.tsx 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2866      +/-   ##
==========================================
+ Coverage   72.61%   72.89%   +0.27%     
==========================================
  Files         264      264              
  Lines        9981    10012      +31     
  Branches     1168     1181      +13     
==========================================
+ Hits         7248     7298      +50     
+ Misses       2391     2371      -20     
- Partials      342      343       +1     
Flag Coverage Δ
backend 83.24% <ø> (-0.11%) ⬇️
frontend 63.29% <58.92%> (+0.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as ready for review January 4, 2024 13:34
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit c702bd1 into master Jan 16, 2024
17 checks passed
@imnasnainaec imnasnainaec deleted the new-entry-empty-dup branch January 16, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When adding sense to entry with empty sense, allow auto-merging with that sense.
3 participants