-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up backend Word/Sense models #2867
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2867 +/- ##
==========================================
- Coverage 72.32% 72.29% -0.04%
==========================================
Files 257 257
Lines 9521 9524 +3
Branches 1097 1096 -1
==========================================
- Hits 6886 6885 -1
- Misses 2308 2311 +3
- Partials 327 328 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @imnasnainaec)
Backend/Models/Sense.cs
line 134 at r1 (raw file):
/// <summary> Adds all semantic domains from other Sense. </summary> public int AddNewDomains(Sense other, string userId)
CopyDomains
would be a better name. AddNewDomains
suggests (to me) that I am providing a list of domains to be added - unrelated to another sense.
Code quote:
AddNewDomains
Backend/Models/Sense.cs
line 134 at r1 (raw file):
/// <summary> Adds all semantic domains from other Sense. </summary> public int AddNewDomains(Sense other, string userId)
Method should not return int
. It is never used.
Code quote:
int
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @jmgrady)
Backend/Models/Sense.cs
line 134 at r1 (raw file):
Previously, jmgrady (Jim Grady) wrote…
Method should not return
int
. It is never used.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
This change is