Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up backend Word/Sense models #2867

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Clean up backend Word/Sense models #2867

merged 2 commits into from
Jan 5, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 3, 2024

This change is Reviewable

@imnasnainaec imnasnainaec added backend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. labels Jan 3, 2024
@imnasnainaec imnasnainaec self-assigned this Jan 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (48cedae) 72.32% compared to head (62c945c) 72.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2867      +/-   ##
==========================================
- Coverage   72.32%   72.29%   -0.04%     
==========================================
  Files         257      257              
  Lines        9521     9524       +3     
  Branches     1097     1096       -1     
==========================================
- Hits         6886     6885       -1     
- Misses       2308     2311       +3     
- Partials      327      328       +1     
Flag Coverage Δ
backend 82.86% <100.00%> (-0.08%) ⬇️
frontend 62.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @imnasnainaec)


Backend/Models/Sense.cs line 134 at r1 (raw file):

        /// <summary> Adds all semantic domains from other Sense. </summary>
        public int AddNewDomains(Sense other, string userId)

CopyDomains would be a better name. AddNewDomains suggests (to me) that I am providing a list of domains to be added - unrelated to another sense.

Code quote:

AddNewDomains

Backend/Models/Sense.cs line 134 at r1 (raw file):

        /// <summary> Adds all semantic domains from other Sense. </summary>
        public int AddNewDomains(Sense other, string userId)

Method should not return int. It is never used.

Code quote:

int

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @jmgrady)


Backend/Models/Sense.cs line 134 at r1 (raw file):

Previously, jmgrady (Jim Grady) wrote…

Method should not return int. It is never used.

Done.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit edeeda5 into master Jan 5, 2024
17 checks passed
@imnasnainaec imnasnainaec deleted the sense-sem-doms branch January 5, 2024 13:20
jmgrady pushed a commit that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants