Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StepSecurity] ci: Harden GitHub Actions #2880

Conversation

step-security-bot
Copy link
Contributor

@step-security-bot step-security-bot commented Jan 11, 2024

Summary

This pull request is created by StepSecurity at the request of @imnasnainaec. Please merge the Pull Request to incorporate the requested changes. Please tag @imnasnainaec on your message if you have any questions related to the PR.

Security Fixes

Pinned Dependencies

GitHub Action tags and Docker tags are mutatble. This poses a security risk. GitHub's Security Hardening guide recommends pinning actions to full length commit.

Feedback

For bug reports, feature requests, and general feedback; please email support@stepsecurity.io. To create such PRs, please visit https://app.stepsecurity.io/securerepo.

Signed-off-by: StepSecurity Bot bot@stepsecurity.io


This change is Reviewable

Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec
Copy link
Collaborator

Our security settings don't allow pinning external actions. From https://github.com/sillsdev/TheCombine/actions/runs/7492028828:

Error: .github#L1
federicocarboni/setup-ffmpeg@583042d is not allowed to be used in sillsdev/TheCombine. Actions in this workflow must be: within a repository owned by sillsdev, created by GitHub, verified in the GitHub Marketplace, or matching the following: federicocarboni/setup-ffmpeg@v2.

@imnasnainaec imnasnainaec merged commit ec3d270 into sillsdev:master Jan 17, 2024
17 checks passed
jmgrady pushed a commit that referenced this pull request Mar 6, 2024
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
Co-authored-by: D. Ror <imnasnainaec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants