Add tls-san option to k3s install options #2886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - change "become: no" to "become: false" - remove microk8s
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2886 +/- ##
==========================================
+ Coverage 72.89% 72.92% +0.02%
==========================================
Files 264 264
Lines 10012 10012
Branches 1181 1181
==========================================
+ Hits 7298 7301 +3
+ Misses 2371 2369 -2
+ Partials 343 342 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
imnasnainaec
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jmgrady)
jmgrady
added a commit
that referenced
this pull request
Mar 6, 2024
Also: - change "become: no" to "become: false" - remove microk8s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the
--tls-sanoption to the install script fork3s.Also:
become: notobecome: false- it is valid ansible YAML but VSCode complainsmicrok8sk8s_dns_nametopublic_dns_nameThis change is