Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Consent Export] Include file-type extensions; Convert webm to wav #2900

Merged
merged 11 commits into from
Feb 13, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 24, 2024

Resolves #2897

Acceptance test:

  • Go to project settings, select the "Users" tab, and go to "Manage speakers" at the bottom
  • Add a speakers and add an audio consent to the speaker:
    • Click the + icon next to one speaker and "Record audio consent"
    • Record some sound
    • Confirm that the + icon is replaced with a green triangle icon
    • Click the green triangle and confirm that you hear the sound
    • Confirm that consent deletion works:
      • Shift click the green triangle and delete the recording
      • Confirm that the + icon is back
    • Add a new recording to the speaker and confirm that it plays
  • Add a second speaker and add an image consent to the speaker:
    • Click the + icon next to this new speaker and "Upload image consent"
    • Select an image file from your computer and upload it
    • Confirm that the + icon is replaced with a generic image icon
    • Click the image icon to confirm that the consent image was uploaded
  • At the top of the project settings, select the "Import/Export" tab
  • Export the project
  • When download is complete, open the downloaded .zip and the folder within
  • Open the "consent" subfolder
  • Confirm that there is a ".wav" file with the sound you recorded
  • Confirm that there is an image file containing the image you uploaded and with the right extension

This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jan 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (0ce9cd0) 72.83% compared to head (3c53bb6) 72.70%.

Files Patch % Lines
Backend/Controllers/SpeakerController.cs 35.29% 6 Missing and 5 partials ⚠️
Backend/Services/LiftService.cs 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2900      +/-   ##
==========================================
- Coverage   72.83%   72.70%   -0.14%     
==========================================
  Files         266      266              
  Lines       10279    10303      +24     
  Branches     1212     1216       +4     
==========================================
+ Hits         7487     7491       +4     
- Misses       2444     2460      +16     
- Partials      348      352       +4     
Flag Coverage Δ
backend 82.94% <35.29%> (-0.32%) ⬇️
frontend 62.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r2, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)


Backend/Controllers/SpeakerController.cs line 247 at r2 (raw file):

            {
                speaker.Consent = ConsentType.Audio;
                extension = ".webm";

So, what if someone uploads a .wav file, or an .ogg file?

@imnasnainaec
Copy link
Collaborator Author

Reviewed 2 of 3 files at r2, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)

Backend/Controllers/SpeakerController.cs line 247 at r2 (raw file):

            {
                speaker.Consent = ConsentType.Audio;
                extension = ".webm";

So, what if someone uploads a .wav file, or an .ogg file?

We currently only support image upload.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 854c085 into master Feb 13, 2024
17 checks passed
@imnasnainaec imnasnainaec deleted the consent-export branch February 13, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve speaker consent export
3 participants