Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MergeDups] Unify reducer with assumption that sidebar must have multiple senses #2907

Merged
merged 19 commits into from
Feb 23, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 31, 2024

This change is Reviewable

@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. goal: MergeDup Size: S Small sized issue labels Jan 31, 2024
@imnasnainaec imnasnainaec self-assigned this Jan 31, 2024
@imnasnainaec imnasnainaec changed the title Use that sidebar can't be open with one sense [MergeDups] Simplify reducer with assumption that sidebar must have multiple senses Jan 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6ea0515) 72.70% compared to head (0642e19) 72.75%.

Files Patch % Lines
...rc/goals/MergeDuplicates/Redux/MergeDupsReducer.ts 88.88% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2907      +/-   ##
==========================================
+ Coverage   72.70%   72.75%   +0.05%     
==========================================
  Files         267      267              
  Lines       10198    10192       -6     
  Branches     1192     1191       -1     
==========================================
+ Hits         7414     7415       +1     
+ Misses       2432     2429       -3     
+ Partials      352      348       -4     
Flag Coverage Δ
backend 82.78% <ø> (ø)
frontend 63.36% <88.88%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec added Size: M Medium sized issue and removed Size: S Small sized issue labels Feb 1, 2024
@imnasnainaec imnasnainaec marked this pull request as ready for review February 1, 2024 16:25
@imnasnainaec imnasnainaec changed the title [MergeDups] Simplify reducer with assumption that sidebar must have multiple senses [MergeDups] Unify reducer with assumption that sidebar must have multiple senses Feb 2, 2024
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit d312c1a into master Feb 23, 2024
17 checks passed
@imnasnainaec imnasnainaec deleted the merge-reducer branch February 23, 2024 19:20
jmgrady pushed a commit that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend goal: MergeDup maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: M Medium sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants