Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RecentEntry] Disable row buttons when editing vern/gloss #2944

Merged
merged 7 commits into from
Feb 23, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Feb 9, 2024

Following feedback from Sara M, this pr smooths out behavior when editing recent entries in the DataEntryTable.
Currently:

  • While the vernacular and gloss are being edited, the buttons in the row (note, recording, delete) can still be clicked, but this creates odd behavior when the row is updated (as soon as the focus moves away from the text field being edited)
  • When changes are made to a recent entry, while the row is updating, the buttons disappear completely, which is visually jarring.

This pr simply disables the buttons in both cases, making the icons gray and unclickable.


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Feb 9, 2024
@imnasnainaec imnasnainaec added the Size: S Small sized issue label Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.80%. Comparing base (d312c1a) to head (2f252b8).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2944   +/-   ##
=======================================
  Coverage   82.80%   82.80%           
=======================================
  Files          47       47           
  Lines        4926     4926           
  Branches      574      574           
=======================================
  Hits         4079     4079           
  Misses        705      705           
  Partials      142      142           
Flag Coverage Δ
backend 82.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as draft February 12, 2024 14:19
@imnasnainaec imnasnainaec marked this pull request as ready for review February 12, 2024 14:32
@imnasnainaec imnasnainaec marked this pull request as draft February 12, 2024 14:45
@imnasnainaec imnasnainaec marked this pull request as ready for review February 12, 2024 15:35
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 8 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) February 23, 2024 19:22
@imnasnainaec imnasnainaec merged commit 179bb36 into master Feb 23, 2024
17 checks passed
@imnasnainaec imnasnainaec deleted the recent-entry-edit branch February 23, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: DataEntry frontend Size: S Small sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants