-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RecentEntry] Disable row buttons when editing vern/gloss #2944
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2944 +/- ##
=======================================
Coverage 82.80% 82.80%
=======================================
Files 47 47
Lines 4926 4926
Branches 574 574
=======================================
Hits 4079 4079
Misses 705 705
Partials 142 142
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 8 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Following feedback from Sara M, this pr smooths out behavior when editing recent entries in the
DataEntryTable
.Currently:
This pr simply disables the buttons in both cases, making the icons gray and unclickable.
This change is