Fix uncalled/impotent test functions

[imnasnainaec]

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.90%. Comparing base (179bb36) to head (cbd3de5).

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #2945       +/-   ##
===========================================
+ Coverage   72.75%   82.90%   +10.15%     
===========================================
  Files         267       47      -220     
  Lines       10204     4926     -5278     
  Branches     1196      574      -622     
===========================================
- Hits         7424     4084     -3340     
+ Misses       2430      701     -1729     
+ Partials      350      141      -209     

Flag	Coverage Δ
backend	82.90% <ø> (+0.12%)	⬆️
frontend	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jasonleenaylor]

Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

---

src/components/DataEntry/DataEntryTable/tests/index.test.tsx line 154 at r1 (raw file):

      expect(mockCreateWord).not.toHaveBeenCalled();
      testHandle = testRenderer.root.findByType(NewEntry);
      expect(testHandle).not.toBeNull;

Why is this not useful?

Code quote:

expect(testHandle).not.toBeNull;

[imnasnainaec]

Reviewable status: 11 of 12 files reviewed, all discussions resolved (waiting on @jasonleenaylor)

---

src/components/DataEntry/DataEntryTable/tests/index.test.tsx line 154 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

Why is this not useful?

findByType() above will just throw an error if one isn't found, and toBeNull needed (), and we have tests below that will fail iftestHandle is not what it's supposed to be.

[jasonleenaylor]

src/components/DataEntry/DataEntryTable/tests/index.test.tsx line 154 at r1 (raw file):

Previously, imnasnainaec (D. Ror.) wrote…

findByType() above will just throw an error if one isn't found, and toBeNull needed (), and we have tests below that will fail iftestHandle is not what it's supposed to be.

👍

[jasonleenaylor]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)