Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataEntry] Trim whitespace off submitted strings #2961

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Feb 20, 2024

Resolves #1250


This change is Reviewable

@imnasnainaec imnasnainaec added maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. component: DataEntry labels Feb 20, 2024
@imnasnainaec imnasnainaec self-assigned this Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 72.77%. Comparing base (8f2f3b3) to head (3c3041e).

Files Patch % Lines
src/components/DataEntry/DataEntryTable/index.tsx 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2961      +/-   ##
==========================================
+ Coverage   72.73%   72.77%   +0.04%     
==========================================
  Files         266      266              
  Lines       10204    10209       +5     
  Branches     1196     1196              
==========================================
+ Hits         7422     7430       +8     
+ Misses       2431     2430       -1     
+ Partials      351      349       -2     
Flag Coverage Δ
backend 82.80% <ø> (+0.10%) ⬆️
frontend 63.42% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 73dd492 into master Mar 21, 2024
17 checks passed
@imnasnainaec imnasnainaec deleted the data-entry-trim branch March 21, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: DataEntry maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure whitespace stripped off any data entered
2 participants