Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up goal redux to match other redux #2974

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Clean up goal redux to match other redux #2974

merged 3 commits into from
Mar 8, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Feb 28, 2024

This change is Reviewable

@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. goal Size: S Small sized issue labels Feb 28, 2024
@imnasnainaec imnasnainaec self-assigned this Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.72%. Comparing base (8bf5264) to head (41ac138).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2974      +/-   ##
==========================================
- Coverage   72.75%   72.72%   -0.04%     
==========================================
  Files         267      266       -1     
  Lines       10204    10200       -4     
  Branches     1196     1196              
==========================================
- Hits         7424     7418       -6     
- Misses       2430     2431       +1     
- Partials      350      351       +1     
Flag Coverage Δ
backend 82.70% <ø> (-0.09%) ⬇️
frontend 63.40% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)


src/components/App/DefaultState.ts line 1 at r1 (raw file):

import { defaultState as goalsState } from "components/GoalTimeline/Redux/GoalReduxTypes";

The component is GoalTimeline, not goal. This should not be changed here.
The component should not be changed to Goal because that would be too confusing since there is another collection of React elements in ./src/goals.

Code quote:

import { defaultState as goalsState } from "components/GoalTimeline/Redux/GoalReduxTypes";

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 21 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec and @jmgrady)


src/components/App/DefaultState.ts line 1 at r1 (raw file):

Previously, jmgrady (Jim Grady) wrote…

The component is GoalTimeline, not goal. This should not be changed here.
The component should not be changed to Goal because that would be too confusing since there is another collection of React elements in ./src/goals.

Ah, very good point. Though with the way components/GoalTimeline/Redux is used, I think it's more fitting to move it to goals/Redux.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 19 of 19 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 842fecf into master Mar 8, 2024
17 checks passed
@imnasnainaec imnasnainaec deleted the goal-redux branch March 8, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend goal maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: S Small sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants