Update install/uninstall scripts #3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3044 +/- ##
=========================================
Coverage ? 82.84%
=========================================
Files ? 47
Lines ? 4956
Branches ? 583
=========================================
Hits ? 4106
Misses ? 705
Partials ? 145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
imnasnainaec
reviewed
Apr 5, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jmgrady)
- add 'set -euo pipefail' to stop script at first failure - remove message about initial user - functionalitiy removed - create Python virtual environment at the beginning of the state machine regardless of initial state
jmgrady
force-pushed
the
update-installer
branch
from
9e29a5f
to
761e2f0
Compare
imnasnainaec
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update install/uninstall scripts as follows:
In addition, these changes are made to the install script:
regardless of initial state
This change is