Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Use more efficient .Length/.Count check #3050

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Apr 10, 2024

In preparation for updated pragma suggestions with .NET 8.0 in #3046.


This change is Reviewable

@imnasnainaec imnasnainaec added backend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: S Small sized issue labels Apr 10, 2024
@imnasnainaec imnasnainaec self-assigned this Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.45%. Comparing base (dea7e6c) to head (da7c0fe).

❗ Current head da7c0fe differs from pull request most recent head b6d07cf. Consider uploading reports for the commit b6d07cf to get more accurate results

Files Patch % Lines
Backend/Services/StatisticsService.cs 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3050      +/-   ##
==========================================
- Coverage   74.29%   73.45%   -0.84%     
==========================================
  Files         269      268       -1     
  Lines       10323    10306      -17     
  Branches     1217     1212       -5     
==========================================
- Hits         7669     7570      -99     
- Misses       2303     2382      +79     
- Partials      351      354       +3     
Flag Coverage Δ
backend 82.92% <75.00%> (ø)
frontend 64.67% <ø> (-1.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec changed the title [Backend] Use more efficient .Length/.Count check [Backend] Use more efficient .Length/.Count check Apr 10, 2024
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) April 17, 2024 13:04
@imnasnainaec imnasnainaec merged commit 5a8006a into master Apr 17, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the any-length branch April 17, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: S Small sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants