Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to README for standalone installer #3055

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

jmgrady
Copy link
Collaborator

@jmgrady jmgrady commented Apr 11, 2024

This PR fixes some errors to the README.md file for the installer script:

  1. Provided missing example to show how to view the current expiration date for The Combine's web certificate; and
  2. changed release numbers in examples to actual release numbers.

This change is Reviewable

@jmgrady jmgrady added the documentation Improvements or additions to documentation label Apr 11, 2024
@jmgrady jmgrady self-assigned this Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.25%. Comparing base (551e086) to head (445a02b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3055      +/-   ##
==========================================
- Coverage   74.29%   74.25%   -0.04%     
==========================================
  Files         269      269              
  Lines       10323    10323              
  Branches     1217     1217              
==========================================
- Hits         7669     7665       -4     
- Misses       2303     2306       +3     
- Partials      351      352       +1     
Flag Coverage Δ
backend 82.84% <ø> (-0.09%) ⬇️
frontend 66.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)

@jmgrady jmgrady merged commit 82f73c4 into master Apr 12, 2024
18 checks passed
@jmgrady jmgrady deleted the installer-readme-edits branch April 12, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants