Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AudioPlayer] Fix the touch-screen long-press behavior #3065

Merged
merged 10 commits into from
Apr 25, 2024
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Apr 19, 2024

Resolves #3011.
Also disables irrelevant tooltip text from appearing when long-pressing the play button
Also disables distracting tooltip text from appearing when long-pressing the record button

Can test with the browser's simulated touchscreen. In Chrome, use "Toggle device toolbar - Ctrl + Shift + M", the blue icon in the top-right of this screenshot:
Screenshot 2024-04-19 162711


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working frontend audio labels Apr 19, 2024
@imnasnainaec imnasnainaec self-assigned this Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.18%. Comparing base (87bcb10) to head (340ce03).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3065      +/-   ##
==========================================
+ Coverage   74.95%   75.18%   +0.23%     
==========================================
  Files         269      269              
  Lines       10361    10373      +12     
  Branches     1226     1227       +1     
==========================================
+ Hits         7766     7799      +33     
+ Misses       2236     2215      -21     
  Partials      359      359              
Flag Coverage Δ
backend 84.15% <ø> (+0.12%) ⬆️
frontend 66.94% <100.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)


src/components/Pronunciations/tests/AudioPlayer.test.tsx line 151 at r2 (raw file):

      jest.advanceTimersByTime(2);
    });
    expect(playMenu.props.open).toBeFalsy();

Should

    expect(mockDispatch).toHaveBeenCalledTimes(1)

be included here?
(I'm fine with it not being here since it is tested in the dispatches on play test.)

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 576733e into master Apr 25, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the audio-tap branch April 25, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audio interaction not working well on touch screens
2 participants