Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Landing Page] Fix broken User Guide button #3066

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Apr 22, 2024

Fixes bug from (#2969) where the User Guide button on the landing page links to https://qa-kube.thecombine.app/docs/[object%20Object].


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working frontend Size: S Small sized issue labels Apr 22, 2024
@imnasnainaec imnasnainaec self-assigned this Apr 22, 2024
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.01%. Comparing base (8bee879) to head (196fb19).

Files Patch % Lines
src/components/LandingPage/LandingButtons.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3066      +/-   ##
==========================================
+ Coverage   74.93%   75.01%   +0.07%     
==========================================
  Files         269      269              
  Lines       10358    10359       +1     
  Branches     1225     1225              
==========================================
+ Hits         7762     7771       +9     
+ Misses       2237     2231       -6     
+ Partials      359      357       -2     
Flag Coverage Δ
backend 84.13% <ø> (+0.18%) ⬆️
frontend 66.61% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec merged commit bc9f532 into master Apr 22, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the bugfix/landing-page-user-guide branch April 22, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Size: S Small sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants