-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Signup] Fix username error bug; Add pw error checks #3067
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3067 +/- ##
==========================================
- Coverage 75.05% 75.00% -0.05%
==========================================
Files 269 269
Lines 10378 10387 +9
Branches 1228 1227 -1
==========================================
+ Hits 7789 7791 +2
- Misses 2227 2234 +7
Partials 362 362
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Fixes bug with the username field:
Adds on-blur error checking to the password fields.
This change is