Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Signup] Fix username error bug; Add pw error checks #3067

Merged
merged 5 commits into from
May 2, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Apr 22, 2024

Fixes bug with the username field:

  • click/tab into the username field
  • don't type a username or type one that is too short (at most 2 characters)
  • click/tab away from the username field
  • observe the red error on the field
  • return to the username field and add a username at least 3 characters long
  • click/tab away from the username field
  • observe that the red error persists, even though it shouldn't

Adds on-blur error checking to the password fields.


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working frontend login/signUp Size: S Small sized issue labels Apr 22, 2024
@imnasnainaec imnasnainaec self-assigned this Apr 22, 2024
@imnasnainaec imnasnainaec changed the title [Login] Fix username error bug; Add pw error checks [SignUp] Fix username error bug; Add pw error checks Apr 22, 2024
@imnasnainaec imnasnainaec changed the title [SignUp] Fix username error bug; Add pw error checks [Signup] Fix username error bug; Add pw error checks Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 75.00%. Comparing base (63c6d71) to head (8afb4ab).

Files Patch % Lines
src/components/Login/Signup.tsx 23.07% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3067      +/-   ##
==========================================
- Coverage   75.05%   75.00%   -0.05%     
==========================================
  Files         269      269              
  Lines       10378    10387       +9     
  Branches     1228     1227       -1     
==========================================
+ Hits         7789     7791       +2     
- Misses       2227     2234       +7     
  Partials      362      362              
Flag Coverage Δ
backend 83.95% <ø> (ø)
frontend 66.80% <23.07%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit dc301f3 into master May 2, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the bugfix/login-onblur-error branch May 2, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend login/signUp Size: S Small sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants