[Recorder] Add backstops for if cursor departs button #3077
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3077 +/- ##
==========================================
- Coverage 75.12% 75.10% -0.03%
==========================================
Files 269 269
Lines 10373 10378 +5
Branches 1227 1228 +1
==========================================
+ Hits 7793 7794 +1
- Misses 2219 2224 +5
+ Partials 361 360 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I think this is a safe step in the right direction, the first Con seems not ideal but it will interact with the improvement @jmgrady was considering of displaying a message and removing accidental recordings. I'm not sure if the interaction will be useful or confusing.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
Mostly fixes #3073
Pro: If the record button is clicked/pressed while a previous recording is still active, that previous recording is finished before a new one is started.
Con: If the record button is clicked/tapped just to end a recording that is still going, a second recording blip will also be created (but at least that is easily deleted).
Pro: If focus shifts away from the button, that will also activate the end of the recording. This works if a user clicks elsewhere.
Con: This doesn't always work if the user taps/presses elsewhere, because the initial recording touch doesn't consistently shift focus to the button in the first place.
This change is