Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Landing Page] Improve layout #3078

Merged
merged 8 commits into from
May 2, 2024
Merged

[Landing Page] Improve layout #3078

merged 8 commits into from
May 2, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Apr 25, 2024

Resolves #3061


This change is Reviewable

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 75.01%. Comparing base (7dbca7d) to head (e32a10e).

Files Patch % Lines
src/components/LandingPage/BottomBar.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3078   +/-   ##
=======================================
  Coverage   75.01%   75.01%           
=======================================
  Files         271      271           
  Lines       10411    10412    +1     
  Branches     1231     1231           
=======================================
+ Hits         7810     7811    +1     
  Misses       2239     2239           
  Partials      362      362           
Flag Coverage Δ
backend 84.03% <ø> (ø)
frontend 66.79% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 4 files at r1, 2 of 2 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 29a699d into master May 2, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the landing-page-narrow branch May 2, 2024 21:57
jmgrady pushed a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LandingPage] Buttons too wide for narrow screen
2 participants