[ReviewEntriesTable] Exempt edit/delete cols from Hide All #3079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imnasnainaec
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3079 +/- ##
=======================================
Coverage 75.04% 75.04%
=======================================
Files 269 269
Lines 10387 10387
Branches 1227 1227
=======================================
Hits 7795 7795
Misses 2231 2231
Partials 361 361
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jmgrady
approved these changes
May 2, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Review Entries tool, click the 3-vertical-bars icon in the top corner to show/hide/rearrange columns. The initial edit column and the final delete column don't show up as options because we want them always one and always on the ends.
Bug: If you click the Hide All button text, the only column that doesn't hide is the Vernacular column. But the edit and delete columns also shouldn't hide.
This change is