-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SummarySenseCard] Add glosses and bg color #3109
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3109 +/- ##
==========================================
+ Coverage 74.77% 74.80% +0.02%
==========================================
Files 277 278 +1
Lines 10652 10652
Branches 1283 1284 +1
==========================================
+ Hits 7965 7968 +3
+ Misses 2320 2319 -1
+ Partials 367 365 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 5 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
src/components/WordCard/index.tsx
line 120 at r3 (raw file):
)) ) : ( <SummarySenseCard includeGlosses senses={senses} />
Why is this a property? It looks to me as though it is always set to true
. Is there a use case that would suggest we would want a SummarySenseCard
without glosses?
Removing the property should simplify the code and the test code so it is worth considering.
If it is not removed, then the test code should be updated to test both cases.
Code quote:
includeGlosses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 6 files reviewed, 1 unresolved discussion (waiting on @jmgrady)
src/components/WordCard/index.tsx
line 120 at r3 (raw file):
Previously, jmgrady (Jim Grady) wrote…
Why is this a property? It looks to me as though it is always set to
true
. Is there a use case that would suggest we would want aSummarySenseCard
without glosses?Removing the property should simplify the code and the test code so it is worth considering.
If it is not removed, then the test code should be updated to test both cases.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Resolves #3104
This change refactors code found in 3 "Data Cleanup" places:
This change is