Fix replace-bug when trying to access local font css file #3111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imnasnainaec
added
bug
imnasnainaec
force-pushed
the
font-css-replace-all
branch
from
40f0c77
to
0839ea5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3111 +/- ##
==========================================
+ Coverage 75.01% 84.03% +9.01%
==========================================
Files 271 47 -224
Lines 10412 4967 -5445
Branches 1231 587 -644
==========================================
- Hits 7811 4174 -3637
+ Misses 2239 647 -1592
+ Partials 362 146 -216
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jmgrady
approved these changes
May 6, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
jmgrady
approved these changes
May 6, 2024
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a css file was stored locally for a font with more than one space (e.g.,
NotoSansGreek.cssforNoto Sans Greek), the bug is that The Combine will look for the file with only the first space removed (e.g.,NotoSans Greek.css). This pr makes sure all spaces are removed, not just the first one.This change is