Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent cross-entry recording interference #3157

Merged
merged 12 commits into from
Jul 8, 2024
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 6, 2024

Resolves #3151

(Had some failing unit tests; fixed by #3156)


This change is Reviewable

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 28.12500% with 23 lines in your changes missing coverage. Please review.

Project coverage is 74.80%. Comparing base (12f00ab) to head (a385e9e).
Report is 47 commits behind head on master.

Files with missing lines Patch % Lines
src/components/Pronunciations/Recorder.ts 0.00% 12 Missing ⚠️
src/components/Pronunciations/AudioRecorder.tsx 0.00% 8 Missing ⚠️
src/components/Pronunciations/RecorderIcon.tsx 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3157      +/-   ##
==========================================
- Coverage   74.83%   74.80%   -0.04%     
==========================================
  Files         277      277              
  Lines       10622    10636      +14     
  Branches     1270     1276       +6     
==========================================
+ Hits         7949     7956       +7     
- Misses       2310     2316       +6     
- Partials      363      364       +1     
Flag Coverage Δ
backend 83.92% <ø> (+0.06%) ⬆️
frontend 66.74% <28.12%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as draft June 7, 2024 12:59
@imnasnainaec imnasnainaec marked this pull request as ready for review June 24, 2024 16:09
@jasonleenaylor
Copy link
Contributor

src/components/Pronunciations/Recorder.ts line 23 at r2 (raw file):

   * If so, returns the `id` used with `startRecording()`.
   * If not, returns `undefined`. */
  isRecording(): string | undefined {

currentRecordingId or getActiveRecorder or getRecorderId - functions that start with is are expected to return a bool value.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after the one method name adjustment I requested.

Reviewed 1 of 3 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) July 8, 2024 21:32
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit ea679bb into master Jul 8, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the cross-entry-record branch July 8, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recording on two different entries back-to-back is broken
2 participants